release/19.x: [OpenMP] Create versioned libgomp softlinks (#112973) #115944
Conversation
Add libgomp.1.dylib for MacOS and libgomp.so.1 for Linux Linkers on Mac and Linux pick up versioned libgomp dynamic library files. The existing softlinks (libgomp.dylib for MacOS and libgomp.so for Linux) are insufficient. This helps alleviate the issue of mixing libgomp and libomp at runtime. (cherry picked from commit eccdb24)
|
@shiltian What do you think about merging this PR to the release branch? |
|
Are we still releasing 19? |
yes. Point releases 19.1.x |
|
Hmm. Is this really a regression? Which is what we usually only fix at this point. It seems like a "feature". What's the risk of this creating problems for users already adopted 19.x? |
It is not a regression but a bug fix. The issue has been there for years. NVHPC ships the similar softlinks to their OpenMP runtime for years. It should be low risk but I’ll let you decide to apply the change to 19.x or not. |
|
I think it makes more sense to do this change in 20.x instead of 19.x. |
I can live with that. |
4 participants
Backport eccdb24
Requested by: @ye-luo